path: root/qobject
diff options
authorKevin Wolf <kwolf@redhat.com>2013-11-20 13:09:21 +0100
committerKevin Wolf <kwolf@redhat.com>2013-11-29 13:40:37 +0100
commit4d5977eaecd3675c1176274a50f74ebc40dd13ec (patch)
treeb7ef6123cd038b6bb5db6eb5742ebd3d9b85b010 /qobject
parent6273d1136af913aaf4badc4545ccf942557c747b (diff)
qdict: Optimise qdict_do_flatten()
Nested QDicts used to be both entered recursively in order to move their entries to the target QDict and also be moved themselves to the target QDict like all other objects. This is harmless because for the top level, qdict_do_flatten() will encounter the (now empty) QDict for a second time and then delete it, but at the same time it's obviously unnecessary overhead. Just delete nested QDicts directly after moving all of their entries. Reported-by: Laszlo Ersek <lersek@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'qobject')
1 files changed, 7 insertions, 3 deletions
diff --git a/qobject/qdict.c b/qobject/qdict.c
index 60d6cd5a0e..17e14f08b1 100644
--- a/qobject/qdict.c
+++ b/qobject/qdict.c
@@ -494,16 +494,20 @@ static void qdict_do_flatten(QDict *qdict, QDict *target, const char *prefix)
delete = false;
if (prefix) {
- qobject_incref(value);
new_key = g_strdup_printf("%s.%s", prefix, entry->key);
- qdict_put_obj(target, new_key, value);
- delete = true;
if (qobject_type(value) == QTYPE_QDICT) {
+ /* Entries of QDicts are processed recursively, the QDict object
+ * itself disappears. */
qdict_do_flatten(qobject_to_qdict(value), target,
new_key ? new_key : entry->key);
delete = true;
+ } else if (prefix) {
+ /* All other objects are moved to the target unchanged. */
+ qobject_incref(value);
+ qdict_put_obj(target, new_key, value);
+ delete = true;