diff options
| author | Max Reitz <mreitz@redhat.com> | 2018-05-09 23:00:18 +0200 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2018-06-11 16:18:45 +0200 |
| commit | d1402b502691142b9cebadd5cb993dc8858e9071 (patch) | |
| tree | cc720c7a6ec91715d85e85ce0fb3ba83ce9155a0 /qemu-img.c | |
| parent | 1f996683ad908fd41c572221a63d9fc31ce04d07 (diff) | |
block: Add Error parameter to bdrv_amend_options
Looking at the qcow2 code that is riddled with error_report() calls,
this is really how it should have been from the start.
Along the way, turn the target_version/current_version comparisons at
the beginning of qcow2_downgrade() into assertions (the caller has to
make sure these conditions are met), and rephrase the error message on
using compat=1.1 to get refcount widths other than 16 bits.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20180509210023.20283-3-mreitz@redhat.com
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'qemu-img.c')
| -rw-r--r-- | qemu-img.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/qemu-img.c b/qemu-img.c index 0be11b3852..df3ec5b7fe 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3810,10 +3810,10 @@ static int img_amend(int argc, char **argv) /* In case the driver does not call amend_status_cb() */ qemu_progress_print(0.f, 0); - ret = bdrv_amend_options(bs, opts, &amend_status_cb, NULL); + ret = bdrv_amend_options(bs, opts, &amend_status_cb, NULL, &err); qemu_progress_print(100.f, 0); if (ret < 0) { - error_report("Error while amending options: %s", strerror(-ret)); + error_report_err(err); goto out; } |