aboutsummaryrefslogtreecommitdiff
path: root/qapi
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2016-06-23 14:20:24 +0200
committerKevin Wolf <kwolf@redhat.com>2016-09-05 19:06:47 +0200
commit0524e93a3fd7bff5bb4a584c372f2632ab7c0e0f (patch)
tree819da417768425c21b050edfdf41db97e4bb00e0 /qapi
parentb7e4fa224200ec87b9599a1d72b16ada35a3d113 (diff)
block: Accept node-name for drive-mirror
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts drive-mirror to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the GenericError error class now instead of DeviceNotFound, because this is what qmp_get_root_bs() returns. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'qapi')
-rw-r--r--qapi/block-core.json5
1 files changed, 3 insertions, 2 deletions
diff --git a/qapi/block-core.json b/qapi/block-core.json
index f081eb8c56..fba1718cef 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1128,7 +1128,7 @@
# See DriveMirror for parameter descriptions
#
# Returns: nothing on success
-# If @device is not a valid block device, DeviceNotFound
+# If @device is not a valid block device, GenericError
#
# Since 1.3
##
@@ -1143,7 +1143,8 @@
# @job-id: #optional identifier for the newly-created block job. If
# omitted, the device name will be used. (Since 2.7)
#
-# @device: the name of the device whose writes should be mirrored.
+# @device: the device name or node-name of a root node whose writes should be
+# mirrored.
#
# @target: the target of the new image. If the file exists, or if it
# is a device, the existing file/device will be used as the new