diff options
| author | Luiz Capitulino <lcapitulino@redhat.com> | 2012-05-14 15:25:20 -0300 |
|---|---|---|
| committer | Michael Roth <mdroth@linux.vnet.ibm.com> | 2012-05-15 09:15:16 -0500 |
| commit | 3674838cd05268954bb6473239cd7f700a79bf0f (patch) | |
| tree | 87b737a98ccd7ed630197b3c5fa094170e6d8160 /qapi-schema-guest.json | |
| parent | d5dd3498ebf4d6dc8661f6a9a69ae10b50f3a6a6 (diff) | |
qemu-ga: guest-shutdown: use only async-signal-safe functions
POSIX mandates[1] that a child process of a multi-thread program uses
only async-signal-safe functions before exec(). We consider qemu-ga
to be multi-thread, because it uses glib.
However, qmp_guest_shutdown() uses functions that are not
async-signal-safe. Fix it the following way:
- fclose() -> reopen_fd_to_null()
- execl() -> execle()
- exit() -> _exit()
- drop slog() usage (which is not safe)
[1] http://pubs.opengroup.org/onlinepubs/009695399/functions/fork.html
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'qapi-schema-guest.json')
| -rw-r--r-- | qapi-schema-guest.json | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index 7c6cb21a79..d4055d262a 100644 --- a/qapi-schema-guest.json +++ b/qapi-schema-guest.json @@ -126,8 +126,7 @@ # @guest-shutdown: # # Initiate guest-activated shutdown. Note: this is an asynchronous -# shutdown request, with no guaruntee of successful shutdown. Errors -# will be logged to guest's syslog. +# shutdown request, with no guarantee of successful shutdown. # # @mode: #optional "halt", "powerdown" (default), or "reboot" # |