aboutsummaryrefslogtreecommitdiff
path: root/os-win32.c
diff options
context:
space:
mode:
authorFabien Chouteau <chouteau@adacore.com>2011-11-07 15:36:14 +0100
committerAnthony Liguori <aliguori@us.ibm.com>2011-11-09 12:06:20 -0600
commitbfc763fcfa80d89d31c4f801c2a82130dd92c708 (patch)
treeeac1aee304fd81d15f7207a8ecbda45a93890083 /os-win32.c
parentcca5de7389ff850ab19d4458da6a0c22ccbac976 (diff)
Replace WriteFileEx with WriteFile in qemu_create_pidfile
The function that writes pidfile for win32 uses WriteFileEx which is an asynchronous IO function. The arguments given to WriteFileEx are allocated on the stack and one of them is "in out". When the IO operation is actually executed the calling function has already returned, so the arguments are no longer allocated or allocated to another frame. Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Fabien Chouteau <chouteau@adacore.com> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'os-win32.c')
-rw-r--r--os-win32.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/os-win32.c b/os-win32.c
index 79094016f1..8ad5fa1fc3 100644
--- a/os-win32.c
+++ b/os-win32.c
@@ -130,14 +130,15 @@ int qemu_create_pidfile(const char *filename)
memset(&overlap, 0, sizeof(overlap));
file = CreateFile(filename, GENERIC_WRITE, FILE_SHARE_READ, NULL,
- OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
+ OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
if (file == INVALID_HANDLE_VALUE) {
return -1;
}
len = snprintf(buffer, sizeof(buffer), "%d\n", getpid());
- ret = WriteFileEx(file, (LPCVOID)buffer, (DWORD)len,
- &overlap, NULL);
+ ret = WriteFile(file, (LPCVOID)buffer, (DWORD)len,
+ NULL, &overlap);
+ CloseHandle(file);
if (ret == 0) {
return -1;
}