aboutsummaryrefslogtreecommitdiff
path: root/migration.c
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2013-07-29 15:01:57 +0200
committerStefan Hajnoczi <stefanha@redhat.com>2013-07-29 17:18:54 +0200
commit9287ac271d83166f99e050a0e0a4ebd462f7eb2b (patch)
tree5e5563d6e107fe73724af493f7025d181374c675 /migration.c
parentb681a1c73e15e08c70c10cccd9c9f5b65cca12e8 (diff)
downloadqemu-arm-9287ac271d83166f99e050a0e0a4ebd462f7eb2b.tar.gz
migration: notify migration state before starting thread
The migration thread runs outside the QEMU global mutex when possible. Therefore we must notify migration state change *before* starting the migration thread. This allows registered listeners to act before live migration iterations begin. Therefore they can get into a state that allows for live migration. When the migration thread starts everything will be ready. Without this patch there is a race condition during migration setup, depending on whether the migration thread has already transitioned from SETUP to ACTIVE state. Acked-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'migration.c')
-rw-r--r--migration.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/migration.c b/migration.c
index e12e7840e6..a5ed26b0ba 100644
--- a/migration.c
+++ b/migration.c
@@ -658,7 +658,9 @@ void migrate_fd_connect(MigrationState *s)
qemu_file_set_rate_limit(s->file,
s->bandwidth_limit / XFER_LIMIT_RATIO);
+ /* Notify before starting migration thread */
+ notifier_list_notify(&migration_state_notifiers, s);
+
qemu_thread_create(&s->thread, migration_thread, s,
QEMU_THREAD_JOINABLE);
- notifier_list_notify(&migration_state_notifiers, s);
}