diff options
| author | Gerd Hoffmann <kraxel@redhat.com> | 2021-09-06 06:55:23 +0200 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2021-11-02 17:24:18 +0100 |
| commit | 58d7d4c7869cb3addb0714aa7b6bd88f2b6b7edf (patch) | |
| tree | 567c1b9036e6d7b08a7bdd9a79ec2debfbc54b18 /include | |
| parent | 7c8d295b274f18f582b931c59dba0cba94f6ca7a (diff) | |
usb-storage: tag usb_msd_csw as packed struct
Without this the struct has the wrong size: sizeof() evaluates
to 16 instead of 13. In most cases the bug is hidden by the
fact that guests submits a buffer which is exactly 13 bytes
long, so the padding added by the compiler is simply ignored.
But sometimes guests submit a larger buffer and expect a short
transfer, which does not work properly with the wrong struct
size.
Cc: vintagepc404@protonmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Fixes: a917d384ac0 ("SCSI TCQ support.")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210906045523.1259629-1-kraxel@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/hw/usb/msd.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/hw/usb/msd.h b/include/hw/usb/msd.h index 7538c54569..54e9f38bda 100644 --- a/include/hw/usb/msd.h +++ b/include/hw/usb/msd.h @@ -17,7 +17,7 @@ enum USBMSDMode { USB_MSDM_CSW /* Command Status. */ }; -struct usb_msd_csw { +struct QEMU_PACKED usb_msd_csw { uint32_t sig; uint32_t tag; uint32_t residue; |