path: root/include/hw
diff options
authorPhilippe Mathieu-Daudé <philmd@redhat.com>2020-07-21 15:05:51 +0200
committerPhilippe Mathieu-Daudé <philmd@redhat.com>2020-07-21 16:47:31 +0200
commita3ad58342a9d88d1baafc0aee39302f79faad480 (patch)
tree2153c2d19eb541d458f6a55b34ccc0def4b4d9da /include/hw
parent90218a9a393c7925f330e7dcc08658e2a01d3bd4 (diff)
hw/nvram/fw_cfg: Simplify fw_cfg_add_from_generator() error propagation
Document FWCfgDataGeneratorClass::get_data() return NULL on error, and non-NULL on success. This allow us to simplify fw_cfg_add_from_generator(). Since we don't need a local variable to propagate the error, we can remove the ERRP_GUARD() macro. Suggested-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20200721131911.27380-2-philmd@redhat.com>
Diffstat (limited to 'include/hw')
1 files changed, 3 insertions, 1 deletions
diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h
index 11feae3177..bbcf405649 100644
--- a/include/hw/nvram/fw_cfg.h
+++ b/include/hw/nvram/fw_cfg.h
@@ -32,7 +32,9 @@ typedef struct FWCfgDataGeneratorClass {
* @obj: the object implementing this interface
* @errp: pointer to a NULL-initialized error object
- * Returns: reference to a byte array containing the data.
+ * Returns: reference to a byte array containing the data on success,
+ * or NULL on error.
+ *
* The caller should release the reference when no longer
* required.