path: root/hw/scsi
diff options
authorDaniel Henrique Barboza <danielhb413@gmail.com>2020-08-20 16:06:35 -0300
committerDavid Gibson <david@gibson.dropbear.id.au>2020-09-08 10:08:42 +1000
commit64dbe2c8b823a64ddda5ddef52b7d5a1ddf35d8f (patch)
tree384fadb3053d8b1c13f51fc30accf3e294676ab1 /hw/scsi
parentc02f9892af1f166634e1b4fd722044151acb5e88 (diff)
spapr_vscsi: do not allow device hotplug
We do not implement hotplug in the vscsi bus, but we forgot to tell qdev about it. The result is that users are able to hotplug devices in the vscsi bus, the devices appear in qdev, but they aren't usable by the guest OS unless the user reboots it first. Setting qbus hotplug_handler to NULL will tell qdev-monitor, via qbus_is_hotpluggable(), that we do not support hotplug operations in spapr_vscsi. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1862059 Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> Message-Id: <20200820190635.379657-1-danielhb413@gmail.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/scsi')
1 files changed, 3 insertions, 0 deletions
diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
index d17dc03c73..57f0a1336f 100644
--- a/hw/scsi/spapr_vscsi.c
+++ b/hw/scsi/spapr_vscsi.c
@@ -1219,6 +1219,9 @@ static void spapr_vscsi_realize(SpaprVioDevice *dev, Error **errp)
scsi_bus_new(&s->bus, sizeof(s->bus), DEVICE(dev),
&vscsi_scsi_info, NULL);
+ /* ibmvscsi SCSI bus does not allow hotplug. */
+ qbus_set_hotplug_handler(BUS(&s->bus), NULL);
void spapr_vscsi_create(SpaprVioBus *bus)