aboutsummaryrefslogtreecommitdiff
path: root/gdbstub.c
diff options
context:
space:
mode:
authorRamiro Polla <ramiro.polla@gmail.com>2019-08-05 21:09:01 +0200
committerAlex Bennée <alex.bennee@linaro.org>2019-08-28 10:11:06 +0100
commit2bdec3984850a093a6bd97cf0a7183dbb877eb38 (patch)
treefa51224097adfb252ab4b48fe52aae1545ef6555 /gdbstub.c
parent23919ddfd56135cad3cb468a8f54d5a595f024f4 (diff)
gdbstub: Fix handling of '!' packet with new infra
Since the '!' packet is not handled by the new infrastructure, gdb_handle_packet() would call run_cmd_parser() with a NULL cmd_parser value, which would lead to an unsupported packet ("$#00") being sent, which could confuse the gdb client. This also has a side-effect of speeding up the initial connection with gdb. Fixes: 3e2c12615b52 ("gdbstub: Implement deatch (D pkt) with new infra") Signed-off-by: Ramiro Polla <ramiro.polla@gmail.com> Message-Id: <20190805190901.14072-1-ramiro.polla@gmail.com> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Diffstat (limited to 'gdbstub.c')
-rw-r--r--gdbstub.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/gdbstub.c b/gdbstub.c
index b92ba59e4d..5c067594ba 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2588,7 +2588,9 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
break;
}
- run_cmd_parser(s, line_buf, cmd_parser);
+ if (cmd_parser) {
+ run_cmd_parser(s, line_buf, cmd_parser);
+ }
return RS_IDLE;
}