diff options
| author | Markus Armbruster <armbru@redhat.com> | 2023-02-07 08:51:05 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2023-02-23 14:00:32 +0100 |
| commit | f969c627e31fe7752fd5c2ff036e587ec9749a25 (patch) | |
| tree | c570299b088db5747d732c716f1ff3973e28a48c /dump | |
| parent | 6f1e91f716a96651feae89dfd674b2ea3bf8e282 (diff) | |
dump: Improve error message when target doesn't support memory dump
The QERR_ macros are leftovers from the days of "rich" error objects.
We've been trying to reduce their remaining use.
Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague
error message
(qemu) dump-guest-memory mumble
Error: this feature or command is not currently supported
to
Error: dumping guest memory is not supported on this target
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230207075115.1525-3-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
[Error message tweaked]
Diffstat (limited to 'dump')
| -rw-r--r-- | dump/dump.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/dump/dump.c b/dump/dump.c index 279b07f09b..e6833e4cc0 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -1854,7 +1854,8 @@ static void dump_init(DumpState *s, int fd, bool has_format, */ ret = cpu_get_dump_info(&s->dump_info, &s->guest_phys_blocks); if (ret < 0) { - error_setg(errp, QERR_UNSUPPORTED); + error_setg(errp, + "dumping guest memory is not supported on this target"); goto cleanup; } |