diff options
| author | Markus Armbruster <armbru@redhat.com> | 2023-02-07 08:51:06 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2023-02-23 14:10:17 +0100 |
| commit | f1a4697c236aae8f7d13042e4c6a31c228aa8595 (patch) | |
| tree | 6cf4594315bd9443ca3ca404d574bbe646868aee /dump | |
| parent | f969c627e31fe7752fd5c2ff036e587ec9749a25 (diff) | |
dump: Assert cpu_get_note_size() can't fail
The only way cpu_get_note_size() can return a negative value is
integer overflow in the non-stub versions, which is a programming
error. The stub version is not actually reachable, because the
cpu_get_dump_info() stub will fail first. Use assert(). This gets
rid of another use of QERR_UNSUPPORTED.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230207075115.1525-4-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'dump')
| -rw-r--r-- | dump/dump.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/dump/dump.c b/dump/dump.c index e6833e4cc0..1362810991 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -1865,10 +1865,7 @@ static void dump_init(DumpState *s, int fd, bool has_format, s->note_size = cpu_get_note_size(s->dump_info.d_class, s->dump_info.d_machine, nr_cpus); - if (s->note_size < 0) { - error_setg(errp, QERR_UNSUPPORTED); - goto cleanup; - } + assert(s->note_size >= 0); /* * The goal of this block is to (a) update the previously guessed |