aboutsummaryrefslogtreecommitdiff
path: root/block-migration.c
diff options
context:
space:
mode:
authorAvishay Traeger <AVISHAY@il.ibm.com>2011-04-06 10:45:36 +0300
committerKevin Wolf <kwolf@redhat.com>2011-04-07 13:51:48 +0200
commit155eb9aa09249874b4ff49e94c58595ad82d3abb (patch)
treed7a2a659329775ecdae2f4d3f4116d5e174a3c7e /block-migration.c
parent7d905f716bea633f2836e1d661387983aacdc6d6 (diff)
downloadqemu-arm-155eb9aa09249874b4ff49e94c58595ad82d3abb.tar.gz
Fix integer overflow in block migration bandwidth calculation
block_mig_state.reads is an int, and multiplying by BLOCK_SIZE yielded a negative number, resulting in a negative bandwidth (running on a 32-bit machine). Change order to avoid. Signed-off-by: Avishay Traeger <avishay@il.ibm.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block-migration.c')
-rw-r--r--block-migration.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block-migration.c b/block-migration.c
index 8218bac09c..576e55a6a3 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -140,7 +140,7 @@ static inline void add_avg_read_time(int64_t time)
static inline long double compute_read_bwidth(void)
{
assert(block_mig_state.total_time != 0);
- return (block_mig_state.reads * BLOCK_SIZE)/ block_mig_state.total_time;
+ return (block_mig_state.reads / block_mig_state.total_time) * BLOCK_SIZE;
}
static int bmds_aio_inflight(BlkMigDevState *bmds, int64_t sector)