path: root/backends
diff options
authorLin Ma <lma@suse.com>2016-09-14 14:22:50 +0800
committerPaolo Bonzini <pbonzini@redhat.com>2016-09-14 22:52:43 +0200
commit71200fb9664c2967a1cdd22b68b0da3a8b2b3eb7 (patch)
treef5710b5de2bd29f2c291320fd22fd04fefacdc55 /backends
parent0d8e065fc5f72462a4664cea501d45e508c5755c (diff)
qemu-char: avoid segfault if user lacks of permisson of a given logfile
Function qemu_chr_alloc returns NULL if it failed to open logfile by any reason, says no write permission. For backends tty, stdio and msmouse, They need to check this return value to avoid segfault in this case. Signed-off-by: Lin Ma <lma@suse.com> Cc: qemu-stable <qemu-stable@nongnu.org> Message-Id: <20160914062250.22226-1-lma@suse.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'backends')
1 files changed, 3 insertions, 0 deletions
diff --git a/backends/msmouse.c b/backends/msmouse.c
index aeb905562d..aceb6dc475 100644
--- a/backends/msmouse.c
+++ b/backends/msmouse.c
@@ -159,6 +159,9 @@ static CharDriverState *qemu_chr_open_msmouse(const char *id,
CharDriverState *chr;
chr = qemu_chr_alloc(common, errp);
+ if (!chr) {
+ return NULL;
+ }
chr->chr_write = msmouse_chr_write;
chr->chr_close = msmouse_chr_close;
chr->chr_accept_input = msmouse_chr_accept_input;