aboutsummaryrefslogtreecommitdiff
path: root/backends
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2014-08-13 13:50:24 +0200
committerMichael S. Tsirkin <mst@redhat.com>2014-08-20 21:15:56 +0200
commit288d3322022d6ad646407f3ca6f1a6a746565b9a (patch)
tree8a43bc27a61b496441418ceb88f8d800f3be51e0 /backends
parent2656eb7c599e306b95bad82b1372fc49ba3088f6 (diff)
hostmem: set MPOL_MF_MOVE
When memory is allocated on a wrong node, MPOL_MF_STRICT doesn't move it - it just fails the allocation. A simple way to reproduce the failure is with mlock=on realtime feature. The code comment actually says: "ensure policy won't be ignored" so setting MPOL_MF_MOVE seems like a better way to do this. Cc: qemu-stable@nongnu.org Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'backends')
-rw-r--r--backends/hostmem.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/backends/hostmem.c b/backends/hostmem.c
index e7eec3756a..99e8f99da8 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -295,7 +295,7 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
/* ensure policy won't be ignored in case memory is preallocated
* before mbind(). note: MPOL_MF_STRICT is ignored on hugepages so
* this doesn't catch hugepage case. */
- unsigned flags = MPOL_MF_STRICT;
+ unsigned flags = MPOL_MF_STRICT | MPOL_MF_MOVE;
/* check for invalid host-nodes and policies and give more verbose
* error messages than mbind(). */