path: root/Makefile.target
diff options
authorWei Liu <wei.liu2@citrix.com>2015-03-09 14:54:33 +0000
committerPaolo Bonzini <pbonzini@redhat.com>2015-04-28 22:14:14 +0200
commit7398dfc7799a50097803db4796c7edb6cd7d47a1 (patch)
tree3a31fcb75fa9f90d2c296bb285b98690a8974a65 /Makefile.target
parent738e4171de478da2516180c7a139f1b762443618 (diff)
Makefile.target: prepend $libs_softmmu to $LIBS
I discovered a problem when trying to build QEMU statically with gcc. libm is an element of LIBS while libpixman-1 is an element in libs_softmmu. Libpixman references functions in libm, so the original ordering makes linking fail. This fix is to reorder $libs_softmmu and $LIBS to make -lm appear after -lpixman-1. However I'm not quite sure if this is the right fix, hence the RFC tag. Normally QEMU is built with c++ compiler which happens to link in libm (at least this is the case with g++), so building QEMU statically normally just works and nobody notices this issue. Signed-off-by: Wei Liu <wei.liu2@citrix.com> Message-Id: <1425912873-21215-1-git-send-email-wei.liu2@citrix.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'Makefile.target')
1 files changed, 1 insertions, 1 deletions
diff --git a/Makefile.target b/Makefile.target
index 2262d89354..1083377403 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -134,7 +134,7 @@ obj-$(CONFIG_KVM) += kvm-all.o
obj-y += memory.o savevm.o cputlb.o
obj-y += memory_mapping.o
obj-y += dump.o
+LIBS := $(libs_softmmu) $(LIBS)
# xen support
obj-$(CONFIG_XEN) += xen-common.o