diff options
authorGuillaume Subiron <maethor@subiron.org>2015-12-19 22:24:55 +0100
committerJason Wang <jasowang@redhat.com>2016-02-04 13:22:06 +0800
commit86c9e1e9d7400c25821ff12cce80336a1cdded59 (patch)
parentd7f053652fef48bee7c461c162c8d4d2c96ab157 (diff)
slirp: goto bad in udp_input if sosendto fails
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent, recording the packet for icmp errors, which does not makes sense since the packet was not actually sent, errors would be related to a previous packet. This patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron <maethor@subiron.org> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Jason Wang <jasowang@redhat.com>
1 files changed, 1 insertions, 0 deletions
diff --git a/slirp/udp.c b/slirp/udp.c
index fee13b4dbd..ce63414c81 100644
--- a/slirp/udp.c
+++ b/slirp/udp.c
@@ -218,6 +218,7 @@ udp_input(register struct mbuf *m, int iphlen)
DEBUG_MISC((dfd,"udp tx errno = %d-%s\n",errno,strerror(errno)));
icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));
+ goto bad;
m_free(so->so_m); /* used for ICMP if error on sorecvfrom */