aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Snow <jsnow@redhat.com>2015-10-05 12:00:55 -0400
committerJohn Snow <jsnow@redhat.com>2015-10-05 12:00:55 -0400
commit3d937150dce20cb95cbaae99b6fd48dca4261f32 (patch)
treec36dc547f8c832acf304213a598b12930eb760ae
parentc0b520dfb8890294a9f8879f4759172900585995 (diff)
downloadqemu-arm-3d937150dce20cb95cbaae99b6fd48dca4261f32.tar.gz
qtest/ahci: fix redundant assertion
Fixes https://bugs.launchpad.net/qemu/+bug/1497711 (!ncq || (ncq && lba48)) is the same as (!ncq || lba48). The intention is simply: "If a command is NCQ, it must also be LBA48." Signed-off-by: John Snow <jsnow@redhat.com> Message-id: 1442868929-17777-1-git-send-email-jsnow@redhat.com
-rw-r--r--tests/libqos/ahci.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index cf66b3e32c..adb2665c6d 100644
--- a/tests/libqos/ahci.c
+++ b/tests/libqos/ahci.c
@@ -742,7 +742,7 @@ AHCICommand *ahci_command_create(uint8_t command_name)
g_assert(!(props->lba28 && props->lba48));
g_assert(!(props->read && props->write));
g_assert(!props->size || props->data);
- g_assert(!props->ncq || (props->ncq && props->lba48));
+ g_assert(!props->ncq || props->lba48);
/* Defaults and book-keeping */
cmd->props = props;