aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCornelia Huck <cornelia.huck@de.ibm.com>2015-03-26 10:41:45 +0100
committerCornelia Huck <cornelia.huck@de.ibm.com>2015-03-30 09:25:17 +0200
commitfa92e218df1d7fcc01e1e5d8bbd77acdaf53c18b (patch)
tree99f6cb08298023bdb24d0cdea19fe78375fc92ee
parentf65025caab916aa8a5b8de270a59078e0b6e2866 (diff)
downloadqemu-arm-fa92e218df1d7fcc01e1e5d8bbd77acdaf53c18b.tar.gz
s390x/ipl: avoid sign extension
Make s390_update_iplstate() return uint32_t to avoid sign extensions for cssids > 127. While this doesn't matter in practice yet (as nobody supports MCSS-E and thus won't see the real cssid), play safe. Reported-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Jason J. Herne <jjherne@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
-rw-r--r--hw/s390x/ipl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
index 5c8661347a..2e26d2aa2c 100644
--- a/hw/s390x/ipl.c
+++ b/hw/s390x/ipl.c
@@ -218,7 +218,7 @@ static Property s390_ipl_properties[] = {
* - -1 if no valid boot device was found
* - ccw id of the boot device otherwise
*/
-static uint64_t s390_update_iplstate(CPUS390XState *env, S390IPLState *ipl)
+static uint32_t s390_update_iplstate(CPUS390XState *env, S390IPLState *ipl)
{
DeviceState *dev_st;