aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGonglei <arei.gonglei@huawei.com>2014-11-15 18:06:42 +0800
committerPaolo Bonzini <pbonzini@redhat.com>2014-11-17 11:41:25 +0100
commit1def74548d8013949c7d4704420d4fdd5fb85268 (patch)
treee7896369ea24c749cada93a581afdb5e71a78d7a
parent77e205a52856adffdd5db70449a8604aa9f66e74 (diff)
downloadqemu-arm-1def74548d8013949c7d4704420d4fdd5fb85268.tar.gz
qga: fix false negative argument passing
Function send_response(s, &qdict->base) returns a negative number when any failures occured. But strerror()'s parameter cannot be negative. Let's change the testing condition and pass '-ret' to strerr(). Signed-off-by: Gonglei <arei.gonglei@huawei.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rw-r--r--qga/main.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/qga/main.c b/qga/main.c
index 227f2bdb88..9939a2b623 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -603,8 +603,8 @@ static void process_event(JSONMessageParser *parser, QList *tokens)
error_free(err);
}
ret = send_response(s, QOBJECT(qdict));
- if (ret) {
- g_warning("error sending error response: %s", strerror(ret));
+ if (ret < 0) {
+ g_warning("error sending error response: %s", strerror(-ret));
}
}