diff options
| author | Cornelia Huck <cohuck@redhat.com> | 2019-07-08 14:34:13 +0200 |
|---|---|---|
| committer | Cornelia Huck <cohuck@redhat.com> | 2019-07-18 11:29:50 +0200 |
| commit | efac5ae420ca0644db9360861a1bf02d040afd18 (patch) | |
| tree | 4e63f03eb54160285a4e552159ee6f17452ddbbb | |
| parent | 0b18cfb8f1828c905139b54c8644b0d8f4aad879 (diff) | |
s390x/pci: add some fallthrough annotations
According to the comment, the bits are supposed to accumulate.
Reported-by: Stefan Weil <sw@weilnetz.de>
Fixes: 5d1abf234462 ("s390x/pci: enforce zPCI state checking")
Acked-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
| -rw-r--r-- | hw/s390x/s390-pci-inst.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c index 61f30b8e55..00235148be 100644 --- a/hw/s390x/s390-pci-inst.c +++ b/hw/s390x/s390-pci-inst.c @@ -1209,8 +1209,10 @@ int stpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar, * FH Enabled bit is set to one in states of ENABLED, BLOCKED or ERROR. */ case ZPCI_FS_ERROR: fib.fc |= 0x20; + /* fallthrough */ case ZPCI_FS_BLOCKED: fib.fc |= 0x40; + /* fallthrough */ case ZPCI_FS_ENABLED: fib.fc |= 0x80; if (pbdev->iommu->enabled) { |