path: root/drivers/remoteproc/qcom_wcnss_iris.c
diff options
authorBjorn Andersson <bjorn.andersson@linaro.org>2016-11-03 19:37:25 -0700
committerBjorn Andersson <bjorn.andersson@linaro.org>2016-11-14 21:52:19 -0800
commit6de1a507c46bf22ed97043495b9ab96e4d5c213b (patch)
treeda576a02806bb50298542d61cbc73e2760737944 /drivers/remoteproc/qcom_wcnss_iris.c
parentcda8529346935fc86f476999ac4fbfe4e17abf11 (diff)
remoteproc: qcom_wcnss: Fix circular module dependency
The tie between the main WCNSS driver and the IRIS driver causes a circular dependency between the two modules. Neither part makes sense to have on their own so lets merge them into one module. For the sake of picking up the clock and regulator resources described in the iris of_node we need an associated struct device. But, to keep the size of the patch down we continue to represent the IRIS part as its own platform_driver, within the same module, rather than setting up a dummy device. Fixes: aed361adca9f ("remoteproc: qcom: Introduce WCNSS peripheral image loader") Reported-by: Andreas Färber <afaerber@suse.de> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Diffstat (limited to 'drivers/remoteproc/qcom_wcnss_iris.c')
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/remoteproc/qcom_wcnss_iris.c b/drivers/remoteproc/qcom_wcnss_iris.c
index 07ef653cfbdf..e842be58e8c7 100644
--- a/drivers/remoteproc/qcom_wcnss_iris.c
+++ b/drivers/remoteproc/qcom_wcnss_iris.c
@@ -94,14 +94,12 @@ disable_regulators:
return ret;
void qcom_iris_disable(struct qcom_iris *iris)
regulator_bulk_disable(iris->num_vregs, iris->vregs);
static int qcom_iris_probe(struct platform_device *pdev)
@@ -175,7 +173,7 @@ static const struct of_device_id iris_of_match[] = {
MODULE_DEVICE_TABLE(of, iris_of_match);
-static struct platform_driver wcnss_driver = {
+struct platform_driver qcom_iris_driver = {
.probe = qcom_iris_probe,
.remove = qcom_iris_remove,
.driver = {
@@ -183,7 +181,3 @@ static struct platform_driver wcnss_driver = {
.of_match_table = iris_of_match,
-MODULE_DESCRIPTION("Qualcomm Wireless Subsystem Iris driver");