path: root/drivers/i3c
diff options
authorNishka Dasgupta <nishkadg.linux@gmail.com>2019-07-23 16:07:25 +0530
committerBoris Brezillon <boris.brezillon@collabora.com>2019-08-11 10:45:51 +0200
commit91227632fc7a047965dcc41da89a40dc982caae8 (patch)
tree20baaf379dd9199a2a0fa94e136471f489fd26b6 /drivers/i3c
parent934d24a5e1508e73c0001afb54a3916e4270428f (diff)
i3c: master: Add of_node_put() before return
Each iteration of for_each_available_childe_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Add an of_node_put before the return. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Diffstat (limited to 'drivers/i3c')
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index c58729081899..87d0f349dd37 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2048,8 +2048,10 @@ static int of_populate_i3c_bus(struct i3c_master_controller *master)
for_each_available_child_of_node(i3cbus_np, node) {
ret = of_i3c_master_add_dev(master, node);
- if (ret)
+ if (ret) {
+ of_node_put(node);
return ret;
+ }