aboutsummaryrefslogtreecommitdiff
path: root/drivers/i3c
diff options
context:
space:
mode:
authorWenwen Wang <wenwen@cs.uga.edu>2019-08-11 13:33:06 -0500
committerBoris Brezillon <boris.brezillon@collabora.com>2019-08-12 10:11:29 +0200
commit7afe9a4e56658bd659660ea10671831664469e5f (patch)
tree1ab408fe564e4392821a835135fa8ad69bd93650 /drivers/i3c
parentb1ac3a4b9aa2f68d498824f1235788e67b51b486 (diff)
downloadlinux-7afe9a4e56658bd659660ea10671831664469e5f.tar.gz
i3c: master: fix a memory leak bug
In i3c_master_getmwl_locked(), the buffer used for the dest payload data is allocated using kzalloc() in i3c_ccc_cmd_dest_init(). Later on, the length of the dest payload data is checked against 'sizeof(*mwl)'. If they are not equal, -EIO is returned to indicate the error. However, the allocated buffer is not deallocated on this path, leading to a memory leak. To fix the above issue, free the buffer before returning the error. Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Diffstat (limited to 'drivers/i3c')
-rw-r--r--drivers/i3c/master.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index a38fdf325d30..8ff527263f46 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -1041,8 +1041,10 @@ static int i3c_master_getmwl_locked(struct i3c_master_controller *master,
if (ret)
goto out;
- if (dest.payload.len != sizeof(*mwl))
- return -EIO;
+ if (dest.payload.len != sizeof(*mwl)) {
+ ret = -EIO;
+ goto out;
+ }
info->max_write_len = be16_to_cpu(mwl->len);