aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLukasz Pawelczyk <l.pawelczyk@samsung.com>2014-08-29 17:02:54 +0200
committerCasey Schaufler <casey@schaufler-ca.com>2014-08-29 10:10:47 -0700
commitd01757904d9deb619e23c9450218829943a46822 (patch)
treeb4cec0c990d4d6f9f6efc7fb9537e31fedd6ea97
parente95ef49b7f8f497bdb529f4cb1fe228e986b3255 (diff)
Fix a bidirectional UDS connect check typo
The 54e70ec5eb090193b03e69d551fa6771a5a217c4 commit introduced a bidirectional check that should have checked for mutual WRITE access between two labels. Due to a typo the second check was incorrect. Signed-off-by: Lukasz Pawelczyk <l.pawelczyk@samsung.com>
-rw-r--r--security/smack/smack_lsm.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 478d99e0a0eb..00443a9039b8 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -3302,8 +3302,8 @@ static int smack_unix_stream_connect(struct sock *sock,
rc = smk_bu_note("UDS connect", skp, okp->smk_known,
MAY_WRITE, rc);
if (rc == 0) {
- rc = smk_access(okp, okp->smk_known, MAY_WRITE, NULL);
- rc = smk_bu_note("UDS connect", okp, okp->smk_known,
+ rc = smk_access(okp, skp->smk_known, MAY_WRITE, NULL);
+ rc = smk_bu_note("UDS connect", okp, skp->smk_known,
MAY_WRITE, rc);
}
}