diff options
| author | Andrzej Hajda <a.hajda@samsung.com> | 2015-12-14 11:06:00 +0100 |
|---|---|---|
| committer | Maxime Ripard <maxime.ripard@free-electrons.com> | 2015-12-14 13:54:11 +0100 |
| commit | fee3103ac3c0aeab52b337903f5af3cd3b3c02d8 (patch) | |
| tree | 689d6dcb0f74d38fd17db3727b6938f665b7eee6 | |
| parent | b1558f168f4ef5956913d73fe330c4da85c74349 (diff) | |
clk: sunxi: fix handling return value of of_property_match_stringsunxi-clocks-for-4.5
The function can return negative values, so its result should
be assigned to signed variable.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
| -rw-r--r-- | drivers/clk/sunxi/clk-sun8i-bus-gates.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/clk/sunxi/clk-sun8i-bus-gates.c b/drivers/clk/sunxi/clk-sun8i-bus-gates.c index b8c775324a5c..e32d18ba252b 100644 --- a/drivers/clk/sunxi/clk-sun8i-bus-gates.c +++ b/drivers/clk/sunxi/clk-sun8i-bus-gates.c @@ -47,12 +47,12 @@ static void __init sun8i_h3_bus_gates_init(struct device_node *node) return; for (i = 0; i < ARRAY_SIZE(names); i++) { - index = of_property_match_string(node, "clock-names", - names[i]); - if (index < 0) + int idx = of_property_match_string(node, "clock-names", + names[i]); + if (idx < 0) return; - parents[i] = of_clk_get_parent_name(node, index); + parents[i] = of_clk_get_parent_name(node, idx); } clk_data = kmalloc(sizeof(struct clk_onecell_data), GFP_KERNEL); |