summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmey Telawane <ameyt@codeaurora.org>2017-05-03 15:41:14 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-06-12 17:25:53 +0200
commitf1dcd659dd83f12fd207e92351757e12e70528f4 (patch)
tree3d9e4cf232fbfc9657579077496595441524b07e
parent9ec773b3dd2dc13a53c65b40c95ab25b0abd5409 (diff)
downloadarm64-stable-rc-f1dcd659dd83f12fd207e92351757e12e70528f4.tar.gz
tracing: Use strlcpy() instead of strcpy() in __trace_find_cmdline()
commit e09e28671cda63e6308b31798b997639120e2a21 upstream. Strcpy is inherently not safe, and strlcpy() should be used instead. __trace_find_cmdline() uses strcpy() because the comms saved must have a terminating nul character, but it doesn't hurt to add the extra protection of using strlcpy() instead of strcpy(). Link: http://lkml.kernel.org/r/1493806274-13936-1-git-send-email-amit.pundir@linaro.org Signed-off-by: Amey Telawane <ameyt@codeaurora.org> [AmitP: Cherry-picked this commit from CodeAurora kernel/msm-3.10 https://source.codeaurora.org/quic/la/kernel/msm-3.10/commit/?id=2161ae9a70b12cf18ac8e5952a20161ffbccb477] Signed-off-by: Amit Pundir <amit.pundir@linaro.org> [ Updated change log and removed the "- 1" from len parameter ] Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--kernel/trace/trace.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 4c21c0b..e81be04 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -1617,7 +1617,7 @@ static void __trace_find_cmdline(int pid, char comm[])
map = savedcmd->map_pid_to_cmdline[pid];
if (map != NO_CMDLINE_MAP)
- strcpy(comm, get_saved_cmdlines(map));
+ strlcpy(comm, get_saved_cmdlines(map), TASK_COMM_LEN);
else
strcpy(comm, "<...>");
}