diff options
authorArtem Savkov <>2016-09-14 07:40:35 +1000
committerGreg Kroah-Hartman <>2017-06-12 17:25:52 +0200
commit31fa29176be633954ee975c84b0e3ca7d2d4a226 (patch)
parentc9b42ca34fbd0d2037a3839f213f1534501c97ea (diff)
Make __xfs_xattr_put_listen preperly report errors.
commit 791cc43b36eb1f88166c8505900cad1b43c7fe1a upstream. Commit 2a6fba6 "xfs: only return -errno or success from attr ->put_listent" changes the returnvalue of __xfs_xattr_put_listen to 0 in case when there is insufficient space in the buffer assuming that setting context->count to -1 would be enough, but all of the ->put_listent callers only check seen_enough. This results in a failed assertion: XFS: Assertion failed: context->count >= 0, file: fs/xfs/xfs_xattr.c, line: 175 in insufficient buffer size case. This is only reproducible with at least 2 xattrs and only when the buffer gets depleted before the last one. Furthermore if buffersize is such that it is enough to hold the last xattr's name, but not enough to hold the sum of preceeding xattr names listxattr won't fail with ERANGE, but will suceed returning last xattr's name without the first character. The first character end's up overwriting data stored at (context->alist - 1). Signed-off-by: Artem Savkov <> Reviewed-by: Dave Chinner <> Signed-off-by: Dave Chinner <> Cc: Nikolay Borisov <> Signed-off-by: Greg Kroah-Hartman <>
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/xfs/xfs_xattr.c b/fs/xfs/xfs_xattr.c
index e6dae28..9beaf19 100644
--- a/fs/xfs/xfs_xattr.c
+++ b/fs/xfs/xfs_xattr.c
@@ -180,6 +180,7 @@ xfs_xattr_put_listent(
arraytop = context->count + prefix_len + namelen + 1;
if (arraytop > context->firstu) {
context->count = -1; /* insufficient space */
+ context->seen_enough = 1;
return 0;
offset = (char *)context->alist + context->count;