path: root/tools/perf
diff options
authorNamhyung Kim <namhyung@gmail.com>2011-12-28 00:35:51 +0900
committerArnaldo Carvalho de Melo <acme@redhat.com>2012-01-03 15:06:34 -0200
commit466e2876bcb9ddc9b92502c46689679bee7d72a0 (patch)
tree169737d7f58146fb69f3c3215bcd3df73dec051a /tools/perf
parent057a174a064f68bac042d618ce3c6ea3ccd9a8aa (diff)
perf script: Kill script_spec__delete
As script_spec__delete() frees given struct script_spec it should not be called if we failed to allocate the struct. Also it's the only caller of the function, we can get rid of the function itself. Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1325000151-4463-4-git-send-email-namhyung@gmail.com Signed-off-by: Namhyung Kim <namhyung@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
1 files changed, 1 insertions, 12 deletions
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 3d4c0c7b576e..fd1909afcfd6 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -536,12 +536,6 @@ static struct script_spec *script_spec__new(const char *spec,
return s;
-static void script_spec__delete(struct script_spec *s)
- free(s->spec);
- free(s);
static void script_spec__add(struct script_spec *s)
list_add_tail(&s->node, &script_specs);
@@ -567,16 +561,11 @@ static struct script_spec *script_spec__findnew(const char *spec,
s = script_spec__new(spec, ops);
if (!s)
- goto out_delete_spec;
+ return NULL;
return s;
- script_spec__delete(s);
- return NULL;
int script_spec_register(const char *spec, struct scripting_ops *ops)