aboutsummaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorSasha Levin <sasha.levin@oracle.com>2015-02-03 08:55:58 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-04-19 10:10:50 +0200
commit8e519c3eb9823f0f6cbffb1dfaede0252df3c350 (patch)
tree8e5fc5696b497621565ec20ed51723db599caac4 /net
parent1f55176763a6556916d4c41c80eba7c69d5d3e5a (diff)
downloadlinux-linaro-stable-8e519c3eb9823f0f6cbffb1dfaede0252df3c350.tar.gz
net: rds: use correct size for max unacked packets and bytes
commit db27ebb111e9f69efece08e4cb6a34ff980f8896 upstream. Max unacked packets/bytes is an int while sizeof(long) was used in the sysctl table. This means that when they were getting read we'd also leak kernel memory to userspace along with the timeout values. Signed-off-by: Sasha Levin <sasha.levin@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
-rw-r--r--net/rds/sysctl.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/rds/sysctl.c b/net/rds/sysctl.c
index 907214b4c4d0..fc6cbe827856 100644
--- a/net/rds/sysctl.c
+++ b/net/rds/sysctl.c
@@ -71,14 +71,14 @@ static ctl_table rds_sysctl_rds_table[] = {
{
.procname = "max_unacked_packets",
.data = &rds_sysctl_max_unacked_packets,
- .maxlen = sizeof(unsigned long),
+ .maxlen = sizeof(int),
.mode = 0644,
.proc_handler = proc_dointvec,
},
{
.procname = "max_unacked_bytes",
.data = &rds_sysctl_max_unacked_bytes,
- .maxlen = sizeof(unsigned long),
+ .maxlen = sizeof(int),
.mode = 0644,
.proc_handler = proc_dointvec,
},