|author||Andrea Arcangeli <email@example.com>||2011-01-25 15:07:25 -0800|
|committer||Linus Torvalds <firstname.lastname@example.org>||2011-01-26 10:50:02 +1000|
mm: compaction: don't depend on HUGETLB_PAGE
Commit 5d6892407 ("thp: select CONFIG_COMPACTION if TRANSPARENT_HUGEPAGE enabled") causes this warning during the configuration process: warning: (TRANSPARENT_HUGEPAGE) selects COMPACTION which has unmet direct dependencies (EXPERIMENTAL && HUGETLB_PAGE && MMU) COMPACTION doesn't depend on HUGETLB_PAGE, it doesn't depend on THP either, it is also useful for regular alloc_pages(order > 0) including the very kernel stack during fork (THREAD_ORDER = 1). It's always better to enable COMPACTION. The warning should be an error because we would end up with MIGRATION not selected, and COMPACTION wouldn't work without migration (despite it seems to build with an inline migrate_pages returning -ENOSYS). I'd also like to remove EXPERIMENTAL: compaction has been in the kernel for some releases (for full safety the default remains disabled which I think is enough). Signed-off-by: Andrea Arcangeli <email@example.com> Reported-by: Luca Tettamanti <firstname.lastname@example.org> Tested-by: Luca Tettamanti <email@example.com> Cc: Mel Gorman <firstname.lastname@example.org> Signed-off-by: Andrew Morton <email@example.com> Signed-off-by: Linus Torvalds <firstname.lastname@example.org>
Diffstat (limited to 'mm')
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/Kconfig b/mm/Kconfig
index 3ad483bdf505..e9c0c61f2ddd 100644
@@ -179,7 +179,7 @@ config SPLIT_PTLOCK_CPUS
bool "Allow for memory compaction"
- depends on EXPERIMENTAL && HUGETLB_PAGE && MMU
+ depends on MMU
Allows the compaction of memory for the allocation of huge pages.