|author||Hannes Frederic Sowa <firstname.lastname@example.org>||2013-10-19 21:48:53 +0200|
|committer||David S. Miller <email@example.com>||2013-10-19 19:45:35 -0400|
static_key: WARN on usage before jump_label_init was called
Usage of the static key primitives to toggle a branch must not be used before jump_label_init() is called from init/main.c. jump_label_init reorganizes and wires up the jump_entries so usage before that could have unforeseen consequences. Following primitives are now checked for correct use: * static_key_slow_inc * static_key_slow_dec * static_key_slow_dec_deferred * jump_label_rate_limit The x86 architecture already checks this by testing if the default_nop was already replaced with an optimal nop or with a branch instruction. It will panic then. Other architectures don't check for this. Because we need to relax this check for the x86 arch to allow code to transition from default_nop to the enabled state and other architectures did not check for this at all this patch introduces checking on the static_key primitives in a non-arch dependent manner. All checked functions are considered slow-path so the additional check does no harm to performance. The warnings are best observed with earlyprintk. Based on a patch from Andi Kleen. Cc: Steven Rostedt <firstname.lastname@example.org> Cc: Peter Zijlstra <email@example.com> Cc: Andi Kleen <firstname.lastname@example.org> Signed-off-by: Hannes Frederic Sowa <email@example.com> Signed-off-by: David S. Miller <firstname.lastname@example.org>
Diffstat (limited to 'init')
1 files changed, 7 insertions, 0 deletions
diff --git a/init/main.c b/init/main.c
index af310afbef28..27bbec1a5b35 100644
@@ -136,6 +136,13 @@ static char *execute_command;
static char *ramdisk_execute_command;
+ * Used to generate warnings if static_key manipulation functions are used
+ * before jump_label_init is called.
+bool static_key_initialized __read_mostly = false;
* If set, this is an indication to the drivers that reset the underlying
* device before going ahead with the initialization otherwise driver might
* rely on the BIOS and skip the reset operation.