path: root/fs
diff options
authorJ. Bruce Fields <bfields@redhat.com>2014-10-22 14:46:29 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-11-14 08:48:00 -0800
commitb51649f0c028f5cecd2bc55ee5b5901515f2ffc6 (patch)
treef1d8c91daa09f4e402586836c8f40d53cab706e9 /fs
parent770600e703e72e27b66149550ea683b53b758b0c (diff)
nfsd4: fix crash on unknown operation number
commit 51904b08072a8bf2b9ed74d1bd7a5300a614471d upstream. Unknown operation numbers are caught in nfsd4_decode_compound() which sets op->opnum to OP_ILLEGAL and op->status to nfserr_op_illegal. The error causes the main loop in nfsd4_proc_compound() to skip most processing. But nfsd4_proc_compound also peeks ahead at the next operation in one case and doesn't take similar precautions there. Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index 0f9ce13972d0..9240dd1678da 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1191,7 +1191,8 @@ static bool need_wrongsec_check(struct svc_rqst *rqstp)
if (argp->opcnt == resp->opcnt)
return false;
+ if (next->opnum == OP_ILLEGAL)
+ return false;
nextd = OPDESC(next);
* Rest of certain operations will return WRONGSEC