diff options
author | Nicholas Bellinger <nab@linux-iscsi.org> | 2017-02-06 14:28:09 -0800 |
---|---|---|
committer | Sasha Levin <alexander.levin@verizon.com> | 2017-03-06 17:31:13 -0500 |
commit | 3d3dc3aa7be4b05a980a55a4e3fc969df7c6250d (patch) | |
tree | a35ae8dd0629a1d106915180d526e3ba1c4cdd7f /fs | |
parent | 7722fbf8d70329f729339b3631abe06c0a613c91 (diff) |
target: Fix COMPARE_AND_WRITE ref leak for non GOOD status
[ Upstream commit 9b2792c3da1e80f2d460167d319302a24c9ca2b7 ]
This patch addresses a long standing bug where the commit phase
of COMPARE_AND_WRITE would result in a se_cmd->cmd_kref reference
leak if se_cmd->scsi_status returned non SAM_STAT_GOOD.
This would manifest first as a lost SCSI response, and eventual
hung task during fabric driver logout or re-login, as existing
shutdown logic waited for the COMPARE_AND_WRITE se_cmd->cmd_kref
to reach zero.
To address this bug, compare_and_write_post() has been changed
to drop the incorrect !cmd->scsi_status conditional that was
preventing *post_ret = 1 for being set during non SAM_STAT_GOOD
status.
This patch has been tested with SAM_STAT_CHECK_CONDITION status
from normal target_complete_cmd() callback path, as well as the
incoming __target_execute_cmd() submission failure path when
se_cmd->execute_cmd() returns non zero status.
Reported-by: Donald White <dew@datera.io>
Cc: Donald White <dew@datera.io>
Tested-by: Gary Guo <ghg@datera.io>
Cc: Gary Guo <ghg@datera.io>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: <stable@vger.kernel.org> # v3.12+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions