aboutsummaryrefslogtreecommitdiff
path: root/fs/read_write.c
diff options
context:
space:
mode:
authorDavid Vrabel <david.vrabel@citrix.com>2014-03-25 10:38:37 +0000
committerDavid Vrabel <david.vrabel@citrix.com>2014-03-25 11:11:42 +0000
commit5926f87fdaad4be3ed10cec563bf357915e55a86 (patch)
treef44ee105eb3a1bb59ea098788c6949004438cf41 /fs/read_write.c
parent09ed3d5ba06137913960f9c9385f71fc384193ab (diff)
Revert "xen: properly account for _PAGE_NUMA during xen pte translations"
This reverts commit a9c8e4beeeb64c22b84c803747487857fe424b68. PTEs in Xen PV guests must contain machine addresses if _PAGE_PRESENT is set and pseudo-physical addresses is _PAGE_PRESENT is clear. This is because during a domain save/restore (migration) the page table entries are "canonicalised" and uncanonicalised". i.e., MFNs are converted to PFNs during domain save so that on a restore the page table entries may be rewritten with the new MFNs on the destination. This canonicalisation is only done for PTEs that are present. This change resulted in writing PTEs with MFNs if _PAGE_PROTNONE (or _PAGE_NUMA) was set but _PAGE_PRESENT was clear. These PTEs would be migrated as-is which would result in unexpected behaviour in the destination domain. Either a) the MFN would be translated to the wrong PFN/page; b) setting the _PAGE_PRESENT bit would clear the PTE because the MFN is no longer owned by the domain; or c) the present bit would not get set. Symptoms include "Bad page" reports when munmapping after migrating a domain. Signed-off-by: David Vrabel <david.vrabel@citrix.com> Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: <stable@vger.kernel.org> [3.12+]
Diffstat (limited to 'fs/read_write.c')
0 files changed, 0 insertions, 0 deletions