path: root/drivers/usb/dwc3
diff options
authorAmit Virdi <amit.virdi@st.com>2015-01-13 14:27:21 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-01-27 07:52:32 -0800
commita3664806789653adc4d484eb198d927c7eca2283 (patch)
tree8d125d4ae38831a24dfbb2b1d7b369bffdb02852 /drivers/usb/dwc3
parent94b762f0128bb14c2bb284e9ce1f5400a458a0c1 (diff)
usb: dwc3: gadget: Stop TRB preparation after limit is reached
commit 39e60635a01520e8c8ed3946a28c2b98e6a46f79 upstream. DWC3 gadget sets up a pool of 32 TRBs for each EP during initialization. This means, the max TRBs that can be submitted for an EP is fixed to 32. Since the request queue for an EP is a linked list, any number of requests can be queued to it by the gadget layer. However, the dwc3 driver must not submit TRBs more than the pool it has created for. This limit wasn't respected when SG was used resulting in submitting more than the max TRBs, eventually leading to non-transfer of the TRBs submitted over the max limit. Root cause: When SG is used, there are two loops iterating to prepare TRBs: - Outer loop over the request_list - Inner loop over the SG list The code was missing break to get out of the outer loop. Fixes: eeb720fb21d6 (usb: dwc3: gadget: add support for SG lists) Signed-off-by: Amit Virdi <amit.virdi@st.com> Signed-off-by: Felipe Balbi <balbi@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/dwc3')
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index a8a2eb5158b7..87f8fc63b3e1 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -925,6 +925,9 @@ static void dwc3_prepare_trbs(struct dwc3_ep *dep, bool starting)
if (last_one)
+ if (last_one)
+ break;
} else {
dma = req->request.dma;
length = req->request.length;