diff options
| author | Christian Engelmayer <cengelma@gmx.at> | 2014-05-07 21:44:53 +0200 |
|---|---|---|
| committer | Riley Andrews <riandrews@google.com> | 2015-01-13 22:40:52 +0000 |
| commit | 045788ea680a4e204aa832ba3985ee1f6a87abc4 (patch) | |
| tree | 42027cb1d1d160f6fdb9f82827ed9677c2016d21 /drivers/staging/android | |
| parent | 12b727a8f9ba257c8d5882a65661e5a81521e571 (diff) | |
staging: binder: fix usage of uninit scalar in binder_transaction()
Fix the error path when a cookie mismatch is detected. In that case the
function jumps to the exit label without setting the uninitialized, local
variable 'return_error'. Detected by Coverity - CID 201453.
Change-Id: I6c960b7d3ad0adb28fad106a9a0b8cb934013987
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Acked-by: Arve <arve@android.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/android')
| -rw-r--r-- | drivers/staging/android/binder.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index c78411a22562..e8dd7ddcba41 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android/binder.c @@ -1547,6 +1547,7 @@ static void binder_transaction(struct binder_proc *proc, proc->pid, thread->pid, (u64)fp->binder, node->debug_id, (u64)fp->cookie, (u64)node->cookie); + return_error = BR_FAILED_REPLY; goto err_binder_get_ref_for_node_failed; } ref = binder_get_ref_for_node(target_proc, node); |