diff options
author | Will Deacon <will.deacon@arm.com> | 2014-05-27 19:11:58 +0100 |
---|---|---|
committer | Alex Shi <alex.shi@linaro.org> | 2014-06-03 14:58:57 +0800 |
commit | e7b50047ec6734fa64e7519ac9cd0a7ee6ada259 (patch) | |
tree | f11bf1498c60a11b46e9fd61a60b25a0a7215187 /drivers/net | |
parent | 1d7430bda36ba855edf2a417ecbe869f3a47bcb3 (diff) |
arm64: mm: fix pmd_write CoW brokennessv3.14/topic/arm64-hugepages
Commit 9c7e535fcc17 ("arm64: mm: Route pmd thp functions through pte
equivalents") changed the pmd manipulator and accessor functions to
convert the target pmd to a pte, process it with the pte functions, then
convert it back. Along the way, we gained support for PTE_WRITE, however
this is completely ignored by set_pmd_at, and so we fail to set the
PMD_SECT_RDONLY for PMDs, resulting in all sorts of lovely failures (like
CoW not working).
Partially reverting the offending commit (by making use of
PMD_SECT_RDONLY explicitly for pmd_{write,wrprotect,mkwrite} functions)
leads to further issues because pmd_write can then return potentially
incorrect values for page table entries marked as RDONLY, leading to
BUG_ON(pmd_write(entry)) tripping under some THP workloads.
This patch fixes the issue by routing set_pmd_at through set_pte_at,
which correctly takes the PTE_WRITE flag into account. Given that
THP mappings are always anonymous, the additional cache-flushing code
in __sync_icache_dcache won't impose any significant overhead as the
flush will be skipped.
Cc: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Steve Capper <steve.capper@arm.com>
Tested-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
(cherry picked from commit ceb218359de22e70980801d4fa04fffbfc44adb8)
Signed-off-by: Alex Shi <alex.shi@linaro.org>
Diffstat (limited to 'drivers/net')
0 files changed, 0 insertions, 0 deletions