path: root/drivers/net
diff options
authorTejun Heo <tj@kernel.org>2017-02-08 15:19:07 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-02-26 11:07:51 +0100
commitde5634875b604674561bf2e97ef58f213c83bc30 (patch)
treec7a54307e228856adcf1c24dc4384586b9ca7e7c /drivers/net
parent15696979d80f9a978496878eade032fba23bb06b (diff)
block: fix double-free in the failure path of cgwb_bdi_init()
commit 5f478e4ea5c5560b4e40eb136991a09f9389f331 upstream. When !CONFIG_CGROUP_WRITEBACK, bdi has single bdi_writeback_congested at bdi->wb_congested. cgwb_bdi_init() allocates it with kzalloc() and doesn't do further initialization. This usually works fine as the reference count gets bumped to 1 by wb_init() and the put from wb_exit() releases it. However, when wb_init() fails, it puts the wb base ref automatically freeing the wb and the explicit kfree() in cgwb_bdi_init() error path ends up trying to free the same pointer the second time causing a double-free. Fix it by explicitly initilizing the refcnt to 1 and putting the base ref from cgwb_bdi_destroy(). Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Dmitry Vyukov <dvyukov@google.com> Fixes: a13f35e87140 ("writeback: don't embed root bdi_writeback_congested in bdi_writeback") Signed-off-by: Jens Axboe <axboe@fb.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net')
0 files changed, 0 insertions, 0 deletions