aboutsummaryrefslogtreecommitdiff
path: root/drivers/net/phy
diff options
context:
space:
mode:
authorJulia Lawall <julia.lawall@lip6.fr>2015-10-25 14:57:02 +0100
committerDavid S. Miller <davem@davemloft.net>2015-10-26 22:08:11 -0700
commit447ed7360037b6e38c0206ddcbd04a256ec94099 (patch)
tree7917cf28a1485ce465a4a304c101bf8d897e65a4 /drivers/net/phy
parentbd252796852193277a07da505601a2f407c70e0b (diff)
downloadlinux-linaro-stable-447ed7360037b6e38c0206ddcbd04a256ec94099.tar.gz
netdev/phy: add missing of_node_put
for_each_available_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ local idexpression r.n; expression r,e; @@ for_each_available_child_of_node(r,n) { ... ( of_node_put(n); | e = n | + of_node_put(n); ? break; ) ... } ... when != n // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy')
-rw-r--r--drivers/net/phy/mdio-mux.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c
index 280c7c311f72..908e8d486342 100644
--- a/drivers/net/phy/mdio-mux.c
+++ b/drivers/net/phy/mdio-mux.c
@@ -144,6 +144,7 @@ int mdio_mux_init(struct device *dev,
dev_err(dev,
"Error: Failed to allocate memory for child\n");
ret_val = -ENOMEM;
+ of_node_put(child_bus_node);
break;
}
cb->bus_number = v;