path: root/drivers/media/radio/radio-si4713.c
diff options
authorHans Verkuil <hans.verkuil@cisco.com>2013-01-05 08:52:12 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2013-01-24 18:54:14 -0200
commitce4a3d52888a95473914bd54bcf6c566014fc03e (patch)
tree7f25c33cc3ec3b76886f021dfefe9a5ddabe1624 /drivers/media/radio/radio-si4713.c
parent68d6f84ba0c47e658beff3a4bf0c43acee4b4690 (diff)
[media] radio: set vfl_dir correctly to fix modulator regression
The vfl_dir field should be set to indicate whether a device can receive data, output data or can do both. This is used to let the v4l core know which ioctls should be accepted and which can be refused. Unfortunately, when this field was added the radio modulator drivers were not updated: radio modulators transmit and so vfl_dir should be set to VFL_DIR_TX (or VFL_DIR_M2M in the special case of wl128x). Because of this omission it is not possible to call g/s_modulator for these drivers, which effectively renders them useless. This patch sets the correct vfl_dir value for these drivers, correcting this bug. Thanks to Paul Grinberg for bringing this to my attention. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/radio/radio-si4713.c')
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/radio/radio-si4713.c b/drivers/media/radio/radio-si4713.c
index a082e400ed0f..1507c9d508d7 100644
--- a/drivers/media/radio/radio-si4713.c
+++ b/drivers/media/radio/radio-si4713.c
@@ -250,6 +250,7 @@ static struct video_device radio_si4713_vdev_template = {
.name = "radio-si4713",
.release = video_device_release,
.ioctl_ops = &radio_si4713_ioctl_ops,
+ .vfl_dir = VFL_DIR_TX,
/* Platform driver interface */