path: root/drivers/infiniband/hw/mlx4
diff options
authorPatrick McHardy <kaber@trash.net>2012-08-30 07:01:30 +0000
committerRoland Dreier <roland@purestorage.com>2012-09-30 20:32:33 -0700
commitbea1e22df494a729978e7f2c54f7bda328f74bc3 (patch)
tree89d9e7ce19232caf86b38833fdbacbe8517b1f97 /drivers/infiniband/hw/mlx4
parent979570e02981d4a8fc20b3cc8fd651856c98ee9d (diff)
IPoIB: Fix use-after-free of multicast object
Fix a crash in ipoib_mcast_join_task(). (with help from Or Gerlitz) Commit c8c2afe360b7 ("IPoIB: Use rtnl lock/unlock when changing device flags") added a call to rtnl_lock() in ipoib_mcast_join_task(), which is run from the ipoib_workqueue, and hence the workqueue can't be flushed from the context of ipoib_stop(). In the current code, ipoib_stop() (which doesn't flush the workqueue) calls ipoib_mcast_dev_flush(), which goes and deletes all the multicast entries. This takes place without any synchronization with a possible running instance of ipoib_mcast_join_task() for the same ipoib device, leading to a crash due to NULL pointer dereference. Fix this by making sure that the workqueue is flushed before ipoib_mcast_dev_flush() is called. To make that possible, we move the RTNL-lock wrapped code to ipoib_mcast_join_finish(). Signed-off-by: Patrick McHardy <kaber@trash.net> Cc: <stable@vger.kernel.org> Signed-off-by: Roland Dreier <roland@purestorage.com>
Diffstat (limited to 'drivers/infiniband/hw/mlx4')
0 files changed, 0 insertions, 0 deletions