path: root/drivers/base/regmap
diff options
authorMark Brown <broonie@kernel.org>2015-09-19 07:00:18 -0700
committerMark Brown <broonie@kernel.org>2015-09-19 07:38:11 -0700
commitb763ec17ac762470eec5be8ebcc43e4f8b2c2b82 (patch)
tree3210c0da561a9e0fe9d0b7ccf1a262835ce7d23b /drivers/base/regmap
parent6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f (diff)
regmap: debugfs: Ensure we don't underflow when printing access masks
If a read is attempted which is smaller than the line length then we may underflow the subtraction we're doing with the unsigned size_t type so move some of the calculation to be additions on the right hand side instead in order to avoid this. Reported-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by: Mark Brown <broonie@kernel.org> Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/base/regmap')
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
index f42f2bac6466..1f327898e53d 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -432,7 +432,7 @@ static ssize_t regmap_access_read_file(struct file *file,
/* If we're in the region the user is trying to read */
if (p >= *ppos) {
/* ...but not beyond it */
- if (buf_pos >= count - 1 - tot_len)
+ if (buf_pos + tot_len + 1 >= count)
/* Format the register */