path: root/drivers/base/regmap/regmap.c
diff options
authorMark Brown <broonie@linaro.org>2014-08-26 12:12:17 +0100
committerMark Brown <broonie@linaro.org>2014-08-26 18:34:26 +0100
commit5844a8b9d98ec11ce1d77610daacf3f0a0e14715 (patch)
treea82017b53a229607d45e1913a09c1f2aab82be71 /drivers/base/regmap/regmap.c
parent7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9 (diff)
regmap: Fix handling of volatile registers for format_write() chips
A previous over-zealous factorisation of code means that we only treat registers as volatile if they are readable. For most devices this is fine since normally most registers can be read and volatility implies readability but for format_write() devices where there is no readback from the hardware and we use volatility to mean simply uncacheability this means that we end up treating all registers as cacheble. A bigger refactoring of the code to clarify this is in order but as a fix make a minimal change and only check readability when checking volatility if there is no format_write() operation defined for the device. Signed-off-by: Mark Brown <broonie@linaro.org> Tested-by: Lars-Peter Clausen <lars@metafoo.de> Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/base/regmap/regmap.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 78f43fb2fe84..1cf427bc0d4a 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -109,7 +109,7 @@ bool regmap_readable(struct regmap *map, unsigned int reg)
bool regmap_volatile(struct regmap *map, unsigned int reg)
- if (!regmap_readable(map, reg))
+ if (!map->format.format_write && !regmap_readable(map, reg))
return false;
if (map->volatile_reg)