diff options
author | Johannes Berg <johannes.berg@intel.com> | 2016-01-26 11:29:03 +0100 |
---|---|---|
committer | Sasha Levin <sasha.levin@oracle.com> | 2016-02-15 15:45:28 -0500 |
commit | 5abd25f01c03b52d8aa39813656782917aa10d9b (patch) | |
tree | 5216d390ecc2e8b77f3ba83a8fbde202af8ef407 /arch/arm | |
parent | 8448609ec0b8b36759338905a7a5f620555623d8 (diff) |
rfkill: fix rfkill_fop_read wait_event usage
[ Upstream commit 6736fde9672ff6717ac576e9bba2fd5f3dfec822 ]
The code within wait_event_interruptible() is called with
!TASK_RUNNING, so mustn't call any functions that can sleep,
like mutex_lock().
Since we re-check the list_empty() in a loop after the wait,
it's safe to simply use list_empty() without locking.
This bug has existed forever, but was only discovered now
because all userspace implementations, including the default
'rfkill' tool, use poll() or select() to get a readable fd
before attempting to read.
Cc: stable@vger.kernel.org
Fixes: c64fb01627e24 ("rfkill: create useful userspace interface")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'arch/arm')
0 files changed, 0 insertions, 0 deletions