|author||Jean Delvare <email@example.com>||2005-08-09 20:28:10 +0200|
|committer||Greg Kroah-Hartman <firstname.lastname@example.org>||2005-09-05 09:14:25 -0700|
[PATCH] I2C: Centralize 24RF08 corruption prevention
The 24RF08 corruption would better be prevented at i2c-core level than at chip driver level, for several reasons: * The second quick write should happen as soon as possible after the first one, so as to limit the risk that another command is issued on the bus inbetween, causing the corruption. * As a matter of fact, the protection code at driver level was reworked at least three times already, which proves how hard it is to get it right there, while it's straightforward at i2c-core level. * It's easy to add a new driver that would need the protection, and forget to add it. This did happen already. * As additional probing addresses can be passed to most i2c chip drivers as module parameters, virtually every i2c chip driver would need the protection if we want to be really safe. * Why duplicate code when we can easily avoid it? Signed-off-by: Jean Delvare <email@example.com> Signed-off-by: Greg Kroah-Hartman <firstname.lastname@example.org>
Diffstat (limited to 'Documentation/i2c')
1 files changed, 2 insertions, 0 deletions
diff --git a/Documentation/i2c/porting-clients b/Documentation/i2c/porting-clients
index 5eb8d37cc679..4849dfd6961c 100644
@@ -90,6 +90,8 @@ Technical changes:
device_create_file. Move the driver initialization before any
sysfs file creation.
+ Drop any 24RF08 corruption prevention you find, as this is now done
+ at the i2c-core level, and doing it twice voids it.
* [Init] Limits must not be set by the driver (can be done later in
user-space). Chip should not be reset default (although a module