aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2008-07-14 21:09:23 +0300
committerAdrian Bunk <bunk@kernel.org>2008-07-14 21:09:23 +0300
commit873496a3485950402ee0436c9d17eeb789157b10 (patch)
treebea402d812cd0e2af52bbf8d1075309d92fe869b
parent952ba4e3bd0b3587c4f6f844c0903370e0ec2ac0 (diff)
downloadlinux-linaro-stable-873496a3485950402ee0436c9d17eeb789157b10.tar.gz
sit: Add missing kfree_skb() on pskb_may_pull() failure. (CVE-2008-2136)
Noticed by Paul Marks <paul@pmarks.net>. Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Adrian Bunk <bunk@kernel.org>
-rw-r--r--net/ipv6/sit.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index c2d3e17beae6..ef367f3aa664 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -398,9 +398,9 @@ static int ipip6_rcv(struct sk_buff *skb)
}
icmp_send(skb, ICMP_DEST_UNREACH, ICMP_PROT_UNREACH, 0);
- kfree_skb(skb);
read_unlock(&ipip6_lock);
out:
+ kfree_skb(skb);
return 0;
}