aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBarry Song <Baohua.Song@csr.com>2012-09-27 16:36:10 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-10-31 10:10:21 -0700
commit7a263f0c7f4acdb1b58cf0e59e6a941b819bd550 (patch)
tree59cd6320d8d353d90c91f965a28b2e33eb5f4d49
parent4853c29c3cd5e7d5ea41bc5edd50e16b1882c294 (diff)
downloadlinux-linaro-stable-7a263f0c7f4acdb1b58cf0e59e6a941b819bd550.tar.gz
dmaengine: sirf: fix a typo in moving running dma_desc to active queue
commit 26fd12209c08fe947be1828896ef4ffc5bd0e6df upstream. list_move_tail(&schan->queued, &schan->active) makes the list_empty(schan->queued) undefined, we either should change it to: list_move_tail(schan->queued.next, &schan->active) or list_move_tail(&sdesc->node, &schan->active) Signed-off-by: Barry Song <Baohua.Song@csr.com> Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/dma/sirf-dma.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/sirf-dma.c b/drivers/dma/sirf-dma.c
index 35a329da97fd..c4394892edab 100644
--- a/drivers/dma/sirf-dma.c
+++ b/drivers/dma/sirf-dma.c
@@ -109,7 +109,7 @@ static void sirfsoc_dma_execute(struct sirfsoc_dma_chan *schan)
sdesc = list_first_entry(&schan->queued, struct sirfsoc_dma_desc,
node);
/* Move the first queued descriptor to active list */
- list_move_tail(&schan->queued, &schan->active);
+ list_move_tail(&sdesc->node, &schan->active);
/* Start the DMA transfer */
writel_relaxed(sdesc->width, sdma->base + SIRFSOC_DMA_WIDTH_0 +