diff options
| author | Michal Schmidt <mschmidt@redhat.com> | 2014-06-02 18:25:02 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-06-26 15:10:28 -0400 |
| commit | 6fa2946224569a4f3f975f86193c02c754acc9d8 (patch) | |
| tree | cea2ed76cccc891932c2d13cc3f9e03d0c931ccb | |
| parent | 6ddc168fe00751a47139f5e6fd432aea799c654d (diff) | |
netlink: rate-limit leftover bytes warning and print process name
[ Upstream commit bfc5184b69cf9eeb286137640351c650c27f118a ]
Any process is able to send netlink messages with leftover bytes.
Make the warning rate-limited to prevent too much log spam.
The warning is supposed to help find userspace bugs, so print the
triggering command name to implicate the buggy program.
[v2: Use pr_warn_ratelimited instead of printk_ratelimited.]
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | lib/nlattr.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/nlattr.c b/lib/nlattr.c index 01c67507dc43..60abf1b5545a 100644 --- a/lib/nlattr.c +++ b/lib/nlattr.c @@ -13,6 +13,7 @@ #include <linux/skbuff.h> #include <linux/string.h> #include <linux/types.h> +#include <linux/ratelimit.h> #include <net/netlink.h> static const u16 nla_attr_minlen[NLA_TYPE_MAX+1] = { @@ -197,8 +198,8 @@ int nla_parse(struct nlattr **tb, int maxtype, const struct nlattr *head, } if (unlikely(rem > 0)) - printk(KERN_WARNING "netlink: %d bytes leftover after parsing " - "attributes.\n", rem); + pr_warn_ratelimited("netlink: %d bytes leftover after parsing attributes in process `%s'.\n", + rem, current->comm); err = 0; errout: |