aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-12-02 13:54:00 +0100
committerAlex Shi <alex.shi@linaro.org>2015-12-16 15:29:20 +0800
commit099e2bf963865d74549b347f11a0117caa1b3e92 (patch)
tree32552d04be78144049e207f6a86a28c4a97321cd
parentc682b26287d3bc5f349fd6ff09a17671905f27e3 (diff)
of: Delete unnecessary check before calling "of_node_put()"
The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Grant Likely <grant.likely@linaro.org> (cherry picked from commit c46ca3c8310b61d253a39ff1375ea97912794cd1) Signed-off-by: Alex Shi <alex.shi@linaro.org>
-rw-r--r--drivers/of/unittest.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 1807a0458648..844838e11ef1 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -516,8 +516,7 @@ static void __init of_selftest_changeset(void)
/* Make sure node names are constructed correctly */
selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")),
"'%s' not added\n", n21->full_name);
- if (np)
- of_node_put(np);
+ of_node_put(np);
mutex_lock(&of_mutex);
selftest(!of_changeset_revert(&chgset), "revert failed\n");